Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unnecessary AppState listener warning on some react-native versions #5732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sascha-kaleidoscode
Copy link

@sascha-kaleidoscode sascha-kaleidoscode commented Apr 18, 2023

Summary

On older React Native versions (between 0.65 and 0.69), the AppState.removeEventListener method exists.
The previous query is true and the method is called, but issues a warning that this method is deprecated.
This code change prioritizes checking whether subscription.remove exists.

Changelog

[General] [Fix] - prevent unnecessary AppState listener warning on some react-native versions

@auto-assign auto-assign bot requested a review from surajahmed April 18, 2023 15:41
@vercel
Copy link

vercel bot commented Apr 18, 2023

@sascha-kaleidoscode is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant